svn commit: r1160665 - /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java

[maxcom]

Author: maxcom
Date: Tue Aug 23 12:46:06 2011
New Revision: 1160665

URL: http://svn.apache.org/viewvc?rev=1160665&view=rev
Log:
ZipContainerDetector: fix file descriptor leak

Modified:
    
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java

Modified: 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
URL: 
http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java?rev=1160665&r1=1160664&r2=1160665&view=diff
==============================================================================
--- 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
 (original)
+++ 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pkg/ZipContainerDetector.java
 Tue Aug 23 12:46:06 2011
@@ -71,9 +71,10 @@ public class ZipContainerDetector implem
         }
 
         TemporaryFiles tmp = new TemporaryFiles();
+        ZipFile zip = null;
         try {
             File file = TikaInputStream.get(input, tmp).getFile();
-            ZipFile zip = new ZipFile(file);
+            zip = new ZipFile(file);
 
             MediaType type = detectOpenDocument(zip);
             if (type == null) {
@@ -92,6 +93,12 @@ public class ZipContainerDetector implem
         } catch (IOException e) {
             return MediaType.APPLICATION_ZIP;
         } finally {
+            if (zip!=null) {
+                try {
+                    zip.close();
+                } catch (IOException e) {
+                }
+            }
             tmp.dispose();
         }
     }