svn commit: r1617767 - in /tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser: image/ImageMetadataExtractor.java iptc/IptcAnpaParser.java pdf/PDF2XHTML.java

[nick]

Author: nick
Date: Wed Aug 13 17:05:52 2014
New Revision: 1617767

URL: http://svn.apache.org/r1617767
Log:
Review SimpleDateFormat use, adding comments where OK or potentially an issue, 
for TIKA-1387

Modified:
    
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
    
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
    
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pdf/PDF2XHTML.java

Modified: 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
URL: 
http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java?rev=1617767&r1=1617766&r2=1617767&view=diff
==============================================================================
--- 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
 (original)
+++ 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/image/ImageMetadataExtractor.java
 Wed Aug 13 17:05:52 2014
@@ -245,7 +245,9 @@ public class ImageMetadataExtractor {
     }
     
     static class ExifHandler implements DirectoryHandler {
+        // There's a new ExifHandler for each file processed, so this is 
thread safe
         private static final SimpleDateFormat DATE_UNSPECIFIED_TZ = new 
SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss", Locale.ROOT);
+
         public boolean supports(Class<? extends Directory> directoryType) {
             return directoryType == ExifIFD0Directory.class || 
                     directoryType == ExifSubIFDDirectory.class;

Modified: 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
URL: 
http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java?rev=1617767&r1=1617766&r2=1617767&view=diff
==============================================================================
--- 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
 (original)
+++ 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/iptc/IptcAnpaParser.java
 Wed Aug 13 17:05:52 2014
@@ -744,7 +744,7 @@ public class IptcAnpaParser implements P
             catch (ParseException ep) {
                // failed, but this will just fall through to setting the date 
to now
             }
-            SimpleDateFormat dfo =   new SimpleDateFormat(format_out, 
Locale.ROOT);
+            SimpleDateFormat dfo = new SimpleDateFormat(format_out, 
Locale.ROOT);
             dfo.setTimeZone(TimeZone.getTimeZone("UTC"));
             ftr_datetime = dfo.format(dateunix);
          }

Modified: 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pdf/PDF2XHTML.java
URL: 
http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pdf/PDF2XHTML.java?rev=1617767&r1=1617766&r2=1617767&view=diff
==============================================================================
--- 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pdf/PDF2XHTML.java 
(original)
+++ 
tika/trunk/tika-parsers/src/main/java/org/apache/tika/parser/pdf/PDF2XHTML.java 
Wed Aug 13 17:05:52 2014
@@ -82,7 +82,8 @@ import org.xml.sax.helpers.AttributesImp
 class PDF2XHTML extends PDFTextStripper {
     
     /**
-     * format used for signature dates
+     * Format used for signature dates
+     * TODO Make this thread-safe
      */
     private final SimpleDateFormat dateFormat = new 
SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ", Locale.ROOT);