This is an automated email from the ASF dual-hosted git repository. tallison pushed a commit to branch TIKA-3936 in repository https://gitbox.apache.org/repos/asf/tika.git
commit b7a5d732254aacfc5931367f47e4a4380a64c23c Author: tallison <[email protected]> AuthorDate: Mon Nov 21 08:12:36 2022 -0500 TIKA-3936 -- fix unit test for Windows and add back windows build (with space in path!) --- .github/workflows/main-jdk8-windows-build.yml | 42 ++++++++++++++++++++++ .../apache/tika/async/cli/TikaAsyncCLITest.java | 3 +- 2 files changed, 43 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main-jdk8-windows-build.yml b/.github/workflows/main-jdk8-windows-build.yml new file mode 100644 index 000000000..dec8b0263 --- /dev/null +++ b/.github/workflows/main-jdk8-windows-build.yml @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: main pr build + +on: + push: + branches: [ main ] + pull_request: + branches: [ main ] + + +jobs: + build: + runs-on: windows-latest + strategy: + matrix: + java: [ '1.8' ] + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK ${{ matrix.java }} + - path: "tika main" #include space in path to test commandline calls + uses: actions/setup-java@v1 + with: + java-version: ${{ matrix.java }} + - name: Build with Maven + run: mvn clean test install javadoc:aggregate diff --git a/tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/TikaAsyncCLITest.java b/tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/TikaAsyncCLITest.java index a06f71c39..fc6694c74 100644 --- a/tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/TikaAsyncCLITest.java +++ b/tika-pipes/tika-async-cli/src/test/java/org/apache/tika/async/cli/TikaAsyncCLITest.java @@ -24,7 +24,6 @@ import java.nio.file.Paths; import org.junit.jupiter.api.Test; import org.apache.tika.exception.TikaConfigException; -import org.apache.tika.utils.ProcessUtils; public class TikaAsyncCLITest { @Test @@ -33,7 +32,7 @@ public class TikaAsyncCLITest { assertThrows(TikaConfigException.class, () -> TikaAsyncCLI.main( new String[] { - ProcessUtils.escapeCommandLine(config.toAbsolutePath().toString()) + config.toAbsolutePath().toString() }) ); }
