[tika] branch main updated: TIKA-4135 -- can't rely on English-only messages from Java xml parsers now that we've removed xerces

[tallison]

This is an automated email from the ASF dual-hosted git repository.

tallison pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new 20e17f297 TIKA-4135 -- can't rely on English-only messages from Java 
xml parsers now that we've removed xerces
20e17f297 is described below

commit 20e17f2971c62a76091754914ad633560691f695
Author: tallison <talli...@apache.org>
AuthorDate: Fri Sep 29 14:27:09 2023 -0400

    TIKA-4135 -- can't rely on English-only messages from Java xml parsers now 
that we've removed xerces
---
 .../test/java/org/apache/tika/parser/TestXMLEntityExpansion.java  | 8 --------
 1 file changed, 8 deletions(-)

diff --git 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/parser/TestXMLEntityExpansion.java
 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/parser/TestXMLEntityExpansion.java
index 692c51421..ac96590a3 100644
--- 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/parser/TestXMLEntityExpansion.java
+++ 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-package/src/test/java/org/apache/tika/parser/TestXMLEntityExpansion.java
@@ -66,16 +66,8 @@ public class TestXMLEntityExpansion extends XMLTestBase {
         try {
             parse(testFileName, new ByteArrayInputStream(bytes), parser, 
context);
         } catch (SAXParseException e) {
-            if (e.getMessage() == null || !e.getMessage().contains("entity 
expansions")) {
-                throw new RuntimeException("Should have seen 'entity 
expansions' in the msg", e);
-            }
             ex = true;
         } catch (TikaException e) {
-            Throwable cause = e.getCause();
-            if (cause == null || cause.getMessage() == null ||
-                    !cause.getMessage().contains("entity expansions")) {
-                throw new RuntimeException("Cause should have mentioned 
'entity expansions'", e);
-            }
             ex = true;
         }
         assertTrue(ex, "should have had an exception");