This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new b870bbab2 TIKA-4238: replace deprecated
b870bbab2 is described below

commit b870bbab23105456d62cba21477c3e4ec9d02ecb
Author: Tilman Hausherr <[email protected]>
AuthorDate: Sat Apr 6 12:27:47 2024 +0200

    TIKA-4238: replace deprecated
---
 .../parser/captioning/tf/TensorflowRESTCaptioner.java | 19 +++++++++----------
 .../recognition/tf/TensorflowRESTRecogniser.java      | 17 ++++++++---------
 .../recognition/tf/TensorflowRESTVideoRecogniser.java | 14 +++++++-------
 3 files changed, 24 insertions(+), 26 deletions(-)

diff --git 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/captioning/tf/TensorflowRESTCaptioner.java
 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/captioning/tf/TensorflowRESTCaptioner.java
index f36576d44..8d3320dea 100644
--- 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/captioning/tf/TensorflowRESTCaptioner.java
+++ 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/captioning/tf/TensorflowRESTCaptioner.java
@@ -36,7 +36,8 @@ import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.entity.ByteArrayEntity;
-import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
 import org.json.simple.JSONArray;
 import org.json.simple.JSONObject;
 import org.json.simple.parser.JSONParser;
@@ -104,13 +105,12 @@ public class TensorflowRESTCaptioner implements 
ObjectRecogniser {
 
     @Override
     public void initialize(Map<String, Param> params) throws 
TikaConfigException {
-        try {
-            healthUri = URI.create(apiBaseUri + "/ping");
-            apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
-                    "/caption/image?beam_size=%1$d&max_caption_length=%2$d", 
captions,
-                    maxCaptionLength));
+        healthUri = URI.create(apiBaseUri + "/ping");
+        apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
+                "/caption/image?beam_size=%1$d&max_caption_length=%2$d", 
captions,
+                maxCaptionLength));
 
-            DefaultHttpClient client = new DefaultHttpClient();
+        try (CloseableHttpClient client = HttpClientBuilder.create().build()) {
             HttpResponse response = client.execute(new HttpGet(healthUri));
             available = response.getStatusLine().getStatusCode() == 200;
 
@@ -133,12 +133,11 @@ public class TensorflowRESTCaptioner implements 
ObjectRecogniser {
                                          Metadata metadata, ParseContext 
context)
             throws IOException, SAXException, TikaException {
         List<CaptionObject> capObjs = new ArrayList<>();
-        try {
-            DefaultHttpClient client = new DefaultHttpClient();
+        try (CloseableHttpClient client = HttpClientBuilder.create().build()) {
 
             HttpPost request = new HttpPost(getApiUri(metadata));
 
-            try (UnsynchronizedByteArrayOutputStream byteStream = new 
UnsynchronizedByteArrayOutputStream()) {
+            try (UnsynchronizedByteArrayOutputStream byteStream = 
UnsynchronizedByteArrayOutputStream.builder().get()) {
                 //TODO: convert this to stream, this might cause OOM issue
                 // InputStreamEntity is not working
                 // request.setEntity(new InputStreamEntity(stream, -1));
diff --git 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
index d7734ca06..fa07ef4e2 100644
--- 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
+++ 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTRecogniser.java
@@ -38,7 +38,8 @@ import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpGet;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.entity.ByteArrayEntity;
-import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.xml.sax.ContentHandler;
@@ -106,12 +107,11 @@ public class TensorflowRESTRecogniser implements 
ObjectRecogniser {
 
     @Override
     public void initialize(Map<String, Param> params) throws 
TikaConfigException {
-        try {
-            healthUri = URI.create(apiBaseUri + "/ping");
-            apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
-                    "/classify/image?topn=%1$d&min_confidence=%2$f", topN, 
minConfidence));
+        healthUri = URI.create(apiBaseUri + "/ping");
+        apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
+                "/classify/image?topn=%1$d&min_confidence=%2$f", topN, 
minConfidence));
 
-            DefaultHttpClient client = new DefaultHttpClient();
+        try (CloseableHttpClient client = HttpClientBuilder.create().build()) {
             HttpResponse response = client.execute(new HttpGet(healthUri));
             available = response.getStatusLine().getStatusCode() == 200;
 
@@ -134,12 +134,11 @@ public class TensorflowRESTRecogniser implements 
ObjectRecogniser {
                                             Metadata metadata, ParseContext 
context)
             throws IOException, SAXException, TikaException {
         List<RecognisedObject> recObjs = new ArrayList<>();
-        try {
-            DefaultHttpClient client = new DefaultHttpClient();
+        try (CloseableHttpClient client = HttpClientBuilder.create().build()) {
 
             HttpPost request = new HttpPost(getApiUri(metadata));
 
-            try (UnsynchronizedByteArrayOutputStream byteStream = new 
UnsynchronizedByteArrayOutputStream()) {
+            try (UnsynchronizedByteArrayOutputStream byteStream = 
UnsynchronizedByteArrayOutputStream.builder().get()) {
                 //TODO: convert this to stream, this might cause OOM issue
                 // InputStreamEntity is not working
                 // request.setEntity(new InputStreamEntity(stream, -1));
diff --git 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTVideoRecogniser.java
 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTVideoRecogniser.java
index a568c6458..4094bc416 100644
--- 
a/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTVideoRecogniser.java
+++ 
b/tika-parsers/tika-parsers-ml/tika-parser-advancedmedia-module/src/main/java/org/apache/tika/parser/recognition/tf/TensorflowRESTVideoRecogniser.java
@@ -26,7 +26,8 @@ import java.util.Set;
 import jakarta.ws.rs.core.UriBuilder;
 import org.apache.http.HttpResponse;
 import org.apache.http.client.methods.HttpGet;
-import org.apache.http.impl.client.DefaultHttpClient;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClientBuilder;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -74,13 +75,12 @@ public class TensorflowRESTVideoRecogniser extends 
TensorflowRESTRecogniser {
 
     @Override
     public void initialize(Map<String, Param> params) throws 
TikaConfigException {
-        try {
-            healthUri = URI.create(apiBaseUri + "/ping");
-            apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
-                    "/classify/video?topn=%1$d&min_confidence=%2$f&mode=%3$s", 
topN, minConfidence,
-                    mode));
+        healthUri = URI.create(apiBaseUri + "/ping");
+        apiUri = URI.create(apiBaseUri + String.format(Locale.getDefault(),
+                "/classify/video?topn=%1$d&min_confidence=%2$f&mode=%3$s", 
topN, minConfidence,
+                mode));
 
-            DefaultHttpClient client = new DefaultHttpClient();
+        try (CloseableHttpClient client = HttpClientBuilder.create().build()) {
             HttpResponse response = client.execute(new HttpGet(healthUri));
             available = response.getStatusLine().getStatusCode() == 200;
 

Reply via email to