(tika) branch main updated: TIKA-4531: remove leaky / dead / not needed code, fix javadoc

[tilman]

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/main by this push:
     new e631e58e2 TIKA-4531: remove leaky / dead / not needed code, fix javadoc
e631e58e2 is described below

commit e631e58e2ad22f0783df3520c90ef524aac7fd65
Author: Tilman Hausherr <til...@apache.org>
AuthorDate: Tue Oct 28 12:33:59 2025 +0100

    TIKA-4531: remove leaky / dead / not needed code, fix javadoc
---
 .../tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java      | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java
 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java
index 399c8afef..aaab49b03 100644
--- 
a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java
+++ 
b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/ooxml/AbstractOOXMLExtractor.java
@@ -72,7 +72,7 @@ import org.apache.tika.utils.XMLReaderUtils;
 
 /**
  * Base class for all Tika OOXML extractors.
- * <p/>
+ * <p>
  * Tika extractors decorate POI extractors so that the parsed content of
  * documents is returned as a sequence of XHTML SAX events. Subclasses must
  * implement the buildXHTML method {@link #buildXHTML(XHTMLContentHandler)} 
that
@@ -332,9 +332,8 @@ public abstract class AbstractOOXMLExtractor implements 
OOXMLExtractor {
             return;
         }
 
-        InputStream is = part.getInputStream();
         // Open the POIFS (OLE2) structure and process
-        POIFSFileSystem fs = null;
+        POIFSFileSystem fs;
         try {
             fs = new POIFSFileSystem(part.getInputStream());
         } catch (Exception e) {
@@ -401,9 +400,7 @@ public abstract class AbstractOOXMLExtractor implements 
OOXMLExtractor {
         } catch (IOException e) {
             EmbeddedDocumentUtil.recordEmbeddedStreamException(e, 
parentMetadata);
         } finally {
-            if (fs != null) {
-                fs.close();
-            }
+            fs.close();
             if (stream != null) {
                 stream.close();
             }