This is an automated email from the ASF dual-hosted git repository.

tallison pushed a commit to branch TIKA-4519
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/TIKA-4519 by this push:
     new 121eb7f75 TIKA-4519 -- checkstyle
121eb7f75 is described below

commit 121eb7f7554afcfd4164399bba47c497ec4635d9
Author: tallison <[email protected]>
AuthorDate: Mon Nov 3 14:51:55 2025 -0500

    TIKA-4519 -- checkstyle
---
 .../tika/pipes/emitter/fs/FileSystemEmitter.java   |  6 +++---
 .../pipes/emitter/fs/FileSystemEmitterConfig.java  | 23 +++++++++++++++++++---
 .../tika/pipes/api/emitter/AbstractEmitter.java    |  1 -
 .../apache/tika/pipes/api/emitter/EmitData.java    | 16 +++++++++++++++
 .../apache/tika/pipes/core/async/AsyncEmitter.java |  1 -
 .../tika/pipes/core/async/AsyncProcessor.java      |  1 -
 .../apache/tika/pipes/core/async/EmitDataPair.java | 16 +++++++++++++++
 .../tika/pipes/core/emitter/EmitterManager.java    |  1 -
 .../tika/pipes/core/emitter/EmptyEmitter.java      |  2 --
 .../tika/pipes/core/TikaPipesConfigTest.java       |  4 +---
 .../tika/serialization/PluginConfigLoader.java     | 16 +++++++++++++++
 .../serialization/PluginsConfigDeserializer.java   | 16 +++++++++++++++
 .../serialization/PluginsConfigSerializer.java     | 16 +++++++++++++++
 .../tika/serialization/PluginsConfigTest.java      | 16 +++++++++++++++
 14 files changed, 120 insertions(+), 15 deletions(-)

diff --git 
a/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitter.java
 
b/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitter.java
index 87aed84d2..9b874ef1c 100644
--- 
a/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitter.java
+++ 
b/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitter.java
@@ -131,13 +131,13 @@ public class FileSystemEmitter extends 
AbstractStreamEmitter {
             Files.createDirectories(output.getParent());
         }
         LOG.warn("on exists: {}", config.onExists());
-        if (config.onExists() == ON_EXISTS.REPLACE) {
+        if (config.onExists() == FileSystemEmitterConfig.ON_EXISTS.REPLACE) {
             LOG.warn("copying {}", output);
             Files.copy(inputStream, output, 
StandardCopyOption.REPLACE_EXISTING);
-        } else if (config.onExists() == ON_EXISTS.EXCEPTION) {
+        } else if (config.onExists() == 
FileSystemEmitterConfig.ON_EXISTS.EXCEPTION) {
             LOG.warn("copying 2 {}", output);
             Files.copy(inputStream, output);
-        } else if (config.onExists() == ON_EXISTS.SKIP) {
+        } else if (config.onExists() == 
FileSystemEmitterConfig.ON_EXISTS.SKIP) {
             if (!Files.isRegularFile(output)) {
                 try {
                     LOG.warn("copying 3 {}", output);
diff --git 
a/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitterConfig.java
 
b/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitterConfig.java
index 9106d8b0c..30cc3dec3 100644
--- 
a/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitterConfig.java
+++ 
b/tika-pipes/tika-emitters/tika-emitter-file-system/src/main/java/org/apache/tika/pipes/emitter/fs/FileSystemEmitterConfig.java
@@ -1,15 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.pipes.emitter.fs;
 
 import java.io.IOException;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 
-enum ON_EXISTS {
-    SKIP, EXCEPTION, REPLACE
-}
+
 
 public record FileSystemEmitterConfig(String basePath, String fileExtension, 
ON_EXISTS onExists, boolean prettyPrint) {
 
+    enum ON_EXISTS {
+        SKIP, EXCEPTION, REPLACE
+    }
 
     private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
 
diff --git 
a/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/AbstractEmitter.java
 
b/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/AbstractEmitter.java
index 4d5f73849..46fa7c92e 100644
--- 
a/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/AbstractEmitter.java
+++ 
b/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/AbstractEmitter.java
@@ -22,7 +22,6 @@ import java.util.List;
 import java.util.Properties;
 
 import org.apache.tika.exception.TikaConfigException;
-import org.apache.tika.pipes.api.fetcher.Fetcher;
 
 public abstract class AbstractEmitter implements Emitter {
 
diff --git 
a/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/EmitData.java
 
b/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/EmitData.java
index 3c1b09dbb..6af852a63 100644
--- 
a/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/EmitData.java
+++ 
b/tika-pipes/tika-pipes-api/src/main/java/org/apache/tika/pipes/api/emitter/EmitData.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.pipes.api.emitter;
 
 import java.util.List;
diff --git 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncEmitter.java
 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncEmitter.java
index a985f6ee4..ab8e617e2 100644
--- 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncEmitter.java
+++ 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncEmitter.java
@@ -32,7 +32,6 @@ import org.slf4j.LoggerFactory;
 
 import org.apache.tika.pipes.api.emitter.EmitData;
 import org.apache.tika.pipes.api.emitter.Emitter;
-import org.apache.tika.pipes.core.emitter.EmitDataImpl;
 import org.apache.tika.pipes.core.emitter.EmitterManager;
 import org.apache.tika.utils.ExceptionUtils;
 
diff --git 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncProcessor.java
 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncProcessor.java
index 6abce6093..3782572c4 100644
--- 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncProcessor.java
+++ 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/AsyncProcessor.java
@@ -39,7 +39,6 @@ import org.apache.tika.pipes.core.PipesClient;
 import org.apache.tika.pipes.core.PipesException;
 import org.apache.tika.pipes.core.PipesReporter;
 import org.apache.tika.pipes.core.PipesResult;
-import org.apache.tika.pipes.core.emitter.EmitDataImpl;
 import org.apache.tika.pipes.core.emitter.EmitterManager;
 import org.apache.tika.pipes.core.pipesiterator.PipesIterator;
 import org.apache.tika.pipes.core.pipesiterator.TotalCountResult;
diff --git 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/EmitDataPair.java
 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/EmitDataPair.java
index e51152058..25bc71971 100644
--- 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/EmitDataPair.java
+++ 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/async/EmitDataPair.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.pipes.core.async;
 
 import org.apache.tika.pipes.api.emitter.EmitData;
diff --git 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmitterManager.java
 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmitterManager.java
index 308c56bc2..6549a0df8 100644
--- 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmitterManager.java
+++ 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmitterManager.java
@@ -31,7 +31,6 @@ import org.pf4j.PluginManager;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import org.apache.tika.config.ConfigBase;
 import org.apache.tika.config.Initializable;
 import org.apache.tika.config.InitializableProblemHandler;
 import org.apache.tika.exception.TikaConfigException;
diff --git 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmptyEmitter.java
 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmptyEmitter.java
index c3430ee98..1149e6fe3 100644
--- 
a/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmptyEmitter.java
+++ 
b/tika-pipes/tika-pipes-core/src/main/java/org/apache/tika/pipes/core/emitter/EmptyEmitter.java
@@ -23,8 +23,6 @@ import org.apache.tika.exception.TikaConfigException;
 import org.apache.tika.metadata.Metadata;
 import org.apache.tika.parser.ParseContext;
 import org.apache.tika.pipes.api.emitter.AbstractEmitter;
-import org.apache.tika.pipes.api.emitter.EmitData;
-import org.apache.tika.pipes.api.emitter.Emitter;
 import org.apache.tika.plugins.PluginConfig;
 
 public class EmptyEmitter extends AbstractEmitter {
diff --git 
a/tika-pipes/tika-pipes-core/src/test/java/org/apache/tika/pipes/core/TikaPipesConfigTest.java
 
b/tika-pipes/tika-pipes-core/src/test/java/org/apache/tika/pipes/core/TikaPipesConfigTest.java
index 06e745503..ae59bf64d 100644
--- 
a/tika-pipes/tika-pipes-core/src/test/java/org/apache/tika/pipes/core/TikaPipesConfigTest.java
+++ 
b/tika-pipes/tika-pipes-core/src/test/java/org/apache/tika/pipes/core/TikaPipesConfigTest.java
@@ -17,20 +17,18 @@
 package org.apache.tika.pipes.core;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import org.junit.jupiter.api.Test;
 
 import org.apache.tika.config.AbstractTikaConfigTest;
 import org.apache.tika.exception.TikaConfigException;
-import org.apache.tika.pipes.api.emitter.Emitter;
-import org.apache.tika.pipes.core.emitter.EmitterManager;
 import org.apache.tika.pipes.core.pipesiterator.PipesIterator;
 
 public class TikaPipesConfigTest extends AbstractTikaConfigTest {
     //this handles tests for the newer pipes type configs.
 /*
+    TODO -- reimplent these with json
     @Test
     public void testFetchers() throws Exception {
         FetcherManager m = 
FetcherManager.load(getConfigFilePath("fetchers-config.xml"));
diff --git 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginConfigLoader.java
 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginConfigLoader.java
index 00fd6f151..495ef5115 100644
--- 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginConfigLoader.java
+++ 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginConfigLoader.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.serialization;
 
 import java.io.IOException;
diff --git 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigDeserializer.java
 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigDeserializer.java
index e773c01c9..72370e308 100644
--- 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigDeserializer.java
+++ 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigDeserializer.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.serialization;
 
 import java.io.IOException;
diff --git 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigSerializer.java
 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigSerializer.java
index feadf4ead..baf45acb8 100644
--- 
a/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigSerializer.java
+++ 
b/tika-serialization/src/main/java/org/apache/tika/serialization/PluginsConfigSerializer.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.serialization;
 
 import java.io.IOException;
diff --git 
a/tika-serialization/src/test/java/org/apache/tika/serialization/PluginsConfigTest.java
 
b/tika-serialization/src/test/java/org/apache/tika/serialization/PluginsConfigTest.java
index 56808006a..78bb28ab1 100644
--- 
a/tika-serialization/src/test/java/org/apache/tika/serialization/PluginsConfigTest.java
+++ 
b/tika-serialization/src/test/java/org/apache/tika/serialization/PluginsConfigTest.java
@@ -1,3 +1,19 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.apache.tika.serialization;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;

Reply via email to