(tika) branch branch_3x updated: TIKA-4542: replace File.createTempFile to Files.createTempFile to reduce the read permission to local user, as suggested by Simon Steiner

[tilman]

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch branch_3x
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/branch_3x by this push:
     new 19c52f059 TIKA-4542: replace File.createTempFile to 
Files.createTempFile to reduce the read permission to local user, as suggested 
by Simon Steiner
19c52f059 is described below

commit 19c52f059bb5e4c31e84e5379a088349217e6b64
Author: Tilman Hausherr <til...@apache.org>
AuthorDate: Fri Nov 14 15:28:15 2025 +0100

    TIKA-4542: replace File.createTempFile to Files.createTempFile to reduce 
the read permission to local user, as suggested by Simon Steiner
---
 tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServer.java | 3 ++-
 .../src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git 
a/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServer.java 
b/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServer.java
index c9be5fb33..70e8bcb91 100644
--- a/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServer.java
+++ b/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServer.java
@@ -21,6 +21,7 @@ import static 
io.grpc.health.v1.HealthCheckResponse.ServingStatus;
 import java.io.File;
 import java.io.FileWriter;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
 import java.util.concurrent.TimeUnit;
 
 import com.beust.jcommander.JCommander;
@@ -90,7 +91,7 @@ public class TikaGrpcServer {
         }
         if (tikaConfigXml == null) {
             // Create a default tika config
-            tikaConfigXml = File.createTempFile("tika-config", ".xml");
+            tikaConfigXml = Files.createTempFile("tika-config", 
".xml").toFile();
             try (FileWriter fw = new FileWriter(tikaConfigXml, 
StandardCharsets.UTF_8)) {
                 TikaConfigSerializer.serialize(new TikaConfig(), 
TikaConfigSerializer.Mode.STATIC_FULL, fw, StandardCharsets.UTF_8);
             }
diff --git 
a/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java 
b/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java
index 63ad8a256..6b56e2d67 100644
--- a/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java
+++ b/tika-grpc/src/main/java/org/apache/tika/pipes/grpc/TikaGrpcServerImpl.java
@@ -21,6 +21,7 @@ import java.io.FileWriter;
 import java.io.IOException;
 import java.lang.reflect.InvocationTargetException;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
 import java.util.HashMap;
 import java.util.LinkedHashMap;
 import java.util.List;
@@ -103,7 +104,7 @@ class TikaGrpcServerImpl extends TikaGrpc.TikaImplBase {
             TransformerException, SAXException {
         File tikaConfigFile = new File(tikaConfigPath);
         if (!tikaConfigFile.canWrite()) {
-            File tmpTikaConfigFile = File.createTempFile("configCopy", 
tikaConfigFile.getName());
+            File tmpTikaConfigFile = Files.createTempFile("configCopy", 
tikaConfigFile.getName()).toFile();
             tmpTikaConfigFile.deleteOnExit();
             LOG.info("Tika config file {} is read-only. Making a temporary 
copy to {}", tikaConfigFile, tmpTikaConfigFile);
             String tikaConfigFileContents = 
FileUtils.readFileToString(tikaConfigFile, StandardCharsets.UTF_8);