This is an automated email from the ASF dual-hosted git repository.

tallison pushed a commit to branch TIKA-4585-simplify-serialization
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to 
refs/heads/TIKA-4585-simplify-serialization by this push:
     new 9069feb6c TIKA-4585 -- fix unit test, add comment
9069feb6c is described below

commit 9069feb6c774dc975b8e6a0927b6248f7745da95
Author: tallison <[email protected]>
AuthorDate: Sat Dec 20 23:38:25 2025 -0500

    TIKA-4585 -- fix unit test, add comment
---
 .../src/main/java/org/apache/tika/config/loader/TikaLoader.java         | 1 +
 .../org/apache/tika/serialization/TestParseContextSerialization.java    | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/tika-serialization/src/main/java/org/apache/tika/config/loader/TikaLoader.java
 
b/tika-serialization/src/main/java/org/apache/tika/config/loader/TikaLoader.java
index 115480d6e..f5d2b4d05 100644
--- 
a/tika-serialization/src/main/java/org/apache/tika/config/loader/TikaLoader.java
+++ 
b/tika-serialization/src/main/java/org/apache/tika/config/loader/TikaLoader.java
@@ -169,6 +169,7 @@ public class TikaLoader {
 
     // Pending configs for deferred creation of 
DefaultParser/DefaultDetector/DefaultEncodingDetector
     // These are created in post-processing to avoid double-creation
+    // TODO -- we need to clean up this abomination
     private JsonNode pendingDefaultParserConfig;
     private int pendingDefaultParserIndex = -1;
     private JsonNode pendingDefaultDetectorConfig;
diff --git 
a/tika-serialization/src/test/java/org/apache/tika/serialization/TestParseContextSerialization.java
 
b/tika-serialization/src/test/java/org/apache/tika/serialization/TestParseContextSerialization.java
index b53c7df13..43c2b9cd7 100644
--- 
a/tika-serialization/src/test/java/org/apache/tika/serialization/TestParseContextSerialization.java
+++ 
b/tika-serialization/src/test/java/org/apache/tika/serialization/TestParseContextSerialization.java
@@ -257,7 +257,7 @@ public class TestParseContextSerialization {
         // Should be empty - typed objects are not serialized
         ObjectMapper mapper = createMapper();
         JsonNode root = mapper.readTree(json);
-        assertEquals(0, root.size(), "Typed objects should not be serialized");
+        assertEquals(1, root.size(), "Typed objects should be serialized");
     }
 
     @Test

Reply via email to