svn commit: r1752409 - in /tiles/framework/trunk: tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java

[mck]

Author: mck
Date: Wed Jul 13 12:27:32 2016
New Revision: 1752409

URL: http://svn.apache.org/viewvc?rev=1752409&view=rev
Log:
Fix: squid:S1149, Synchronized classes StringBuffer shouldn't be used
Fix from Ayman Elkfrawy - ayman.elkfr...@devfactory.com
ref: https://github.com/apache/tiles/pull/8
This closes #8

Modified:
    
tiles/framework/trunk/tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java
    
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java

Modified: 
tiles/framework/trunk/tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java
URL: 
http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java?rev=1752409&r1=1752408&r2=1752409&view=diff
==============================================================================
--- 
tiles/framework/trunk/tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java
 (original)
+++ 
tiles/framework/trunk/tiles-compat/src/main/java/org/apache/tiles/beans/SimpleMenuItem.java
 Wed Jul 13 12:27:32 2016
@@ -132,7 +132,7 @@ public class SimpleMenuItem implements M
     /** {@inheritDoc} */
     @Override
     public String toString() {
-        StringBuffer buff = new StringBuffer("SimpleMenuItem[");
+        StringBuilder buff = new StringBuilder("SimpleMenuItem[");
 
         if (getValue() != null) {
             buff.append("value=").append(getValue()).append(", ");

Modified: 
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java
URL: 
http://svn.apache.org/viewvc/tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java?rev=1752409&r1=1752408&r2=1752409&view=diff
==============================================================================
--- 
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java
 (original)
+++ 
tiles/framework/trunk/tiles-core/src/main/java/org/apache/tiles/util/WildcardHelper.java
 Wed Jul 13 12:27:32 2016
@@ -494,8 +494,8 @@ public class WildcardHelper {
         }
 
         Map.Entry<Integer, String> entry;
-        StringBuffer key = new StringBuffer("{0}");
-        StringBuffer ret = new StringBuffer(val);
+        StringBuilder key = new StringBuilder("{0}");
+        StringBuilder ret = new StringBuilder(val);
         String keyTmp;
         int x;