TINKERPOP-1024 Removed tryRandomCommit() on AbstractGremlinTest This method was deprecate some time ago and probably could have been removed without concern. It was only used in testing Neo4j, but the path of deprecation was chosen instead. Removed for 3.3.0. CTR
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/47e2cd74 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/47e2cd74 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/47e2cd74 Branch: refs/heads/TINKERPOP-1235 Commit: 47e2cd74d1ece054c270269404c8aebdb2b58e64 Parents: d5b2bc1 Author: Stephen Mallette <[email protected]> Authored: Wed Oct 26 15:32:14 2016 -0400 Committer: Stephen Mallette <[email protected]> Committed: Wed Oct 26 15:32:14 2016 -0400 ---------------------------------------------------------------------- CHANGELOG.asciidoc | 1 + .../apache/tinkerpop/gremlin/AbstractGremlinTest.java | 12 ------------ 2 files changed, 1 insertion(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/47e2cd74/CHANGELOG.asciidoc ---------------------------------------------------------------------- diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index a48c40c..26e2e89 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -29,6 +29,7 @@ TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET) * Replaced term `REST` with `HTTP` to remove any confusion as to the design of the API. * Moved `gremlin-benchmark` under `gremlin-tools` module. * Added `gremlin-tools` and its submodule `gremlin-coverage`. +* Removed `tryRandomCommit()` from `AbstractGremlinTest`. * Changed `gremlin-benchmark` system property for the report location to `benchmarkReportDir` for consistency. TinkerPop 3.2.0 (Nine Inch Gremlins) http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/47e2cd74/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/AbstractGremlinTest.java ---------------------------------------------------------------------- diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/AbstractGremlinTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/AbstractGremlinTest.java index 8485d56..25d7a55 100644 --- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/AbstractGremlinTest.java +++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/AbstractGremlinTest.java @@ -205,18 +205,6 @@ public abstract class AbstractGremlinTest { } /** - * This method does not appear to be used in TinkerPop core. It was used at one time by Neo4j tests, but wasn't - * really a great pattern and was eventually removed. - * - * @deprecated as of 3.1.1-incubating, and is not replaced - */ - @Deprecated - public void tryRandomCommit(final Graph graph) { - if (graph.features().graph().supportsTransactions() && new Random().nextBoolean()) - graph.tx().commit(); - } - - /** * Utility method that commits if the graph supports transactions and executes an assertion function before and * after the commit. It assumes that the assertion should be true before and after the commit. */
