added a group().profile() test to ProfileTest to verify no NPE.
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/1d715d3d Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/1d715d3d Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/1d715d3d Branch: refs/heads/TINKERPOP-1490 Commit: 1d715d3d7e9d532e7ea3713f4c4c20e0472b88ba Parents: 3d70c3d Author: Marko A. Rodriguez <[email protected]> Authored: Thu Nov 3 10:31:36 2016 -0600 Committer: Marko A. Rodriguez <[email protected]> Committed: Thu Nov 3 10:31:36 2016 -0600 ---------------------------------------------------------------------- .../traversal/step/map/GroovyProfileTest.groovy | 5 +++++ .../process/traversal/step/map/ProfileTest.java | 17 +++++++++++++++++ 2 files changed, 22 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/1d715d3d/gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyProfileTest.groovy ---------------------------------------------------------------------- diff --git a/gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyProfileTest.groovy b/gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyProfileTest.groovy index 0987ee5..f2dbfbf 100644 --- a/gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyProfileTest.groovy +++ b/gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyProfileTest.groovy @@ -84,6 +84,11 @@ public abstract class GroovyProfileTest { public Traversal<Vertex, TraversalMetrics> get_g_V_hasLabelXpersonX_pageRank_byXrankX_byXbothEX_rank_profile() { new ScriptTraversal<>(g, "gremlin-groovy", "g.V.hasLabel('person').pageRank.by('rank').by(bothE()).rank.profile()") } + + @Override + public Traversal<Vertex, TraversalMetrics> get_g_V_groupXmX_profile() { + new ScriptTraversal<>(g, "gremlin-groovy", "g.V.group('m').profile") + } } } http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/1d715d3d/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java ---------------------------------------------------------------------- diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java index 548e7ab..1af6ba3 100644 --- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java +++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ProfileTest.java @@ -54,6 +54,7 @@ import static org.apache.tinkerpop.gremlin.LoadGraphWith.GraphData.GRATEFUL; import static org.apache.tinkerpop.gremlin.LoadGraphWith.GraphData.MODERN; import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.both; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertNotEquals; import static org.junit.Assert.assertTrue; import static org.junit.Assert.fail; @@ -88,6 +89,8 @@ public abstract class ProfileTest extends AbstractGremlinProcessTest { public abstract Traversal<Vertex, TraversalMetrics> get_g_V_hasLabelXpersonX_pageRank_byXrankX_byXbothEX_rank_profile(); + public abstract Traversal<Vertex, TraversalMetrics> get_g_V_groupXmX_profile(); + @Test @LoadGraphWith(MODERN) public void modern_V_out_out_profile() { @@ -409,6 +412,15 @@ public abstract class ProfileTest extends AbstractGremlinProcessTest { } } + @Test + @LoadGraphWith(MODERN) + public void g_V_groupXmX_profile() { + final Traversal<Vertex, TraversalMetrics> traversal = get_g_V_groupXmX_profile(); + printTraversalForm(traversal); + traversal.next(); + assertFalse(traversal.hasNext()); + } + private static boolean onGraphComputer(final Traversal.Admin<?, ?> traversal) { return !TraversalHelper.getStepsOfClass(TraversalVertexProgramStep.class, TraversalHelper.getRootTraversal(traversal)).isEmpty(); } @@ -496,5 +508,10 @@ public abstract class ProfileTest extends AbstractGremlinProcessTest { public Traversal<Vertex, TraversalMetrics> get_g_V_hasLabelXpersonX_pageRank_byXrankX_byXbothEX_rank_profile() { return g.V().hasLabel("person").pageRank().by("rank").by(__.bothE()).values("rank").profile(); } + + @Override + public Traversal<Vertex, TraversalMetrics> get_g_V_groupXmX_profile() { + return g.V().group("m").profile(); + } } }
