TINKERPOP-1892 Add better ignore reasons for tests in Gremlin.Net CTR

Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/bbb13772
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/bbb13772
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/bbb13772

Branch: refs/heads/TRAVIS-TEST
Commit: bbb13772a791ae7116551ba1d62ea7d136fe60c7
Parents: ab66ed3
Author: Florian Hockmann <f...@florian-hockmann.de>
Authored: Sun Mar 11 16:10:17 2018 +0100
Committer: Florian Hockmann <f...@florian-hockmann.de>
Committed: Sun Mar 11 16:10:17 2018 +0100

----------------------------------------------------------------------
 .../Gherkin/GherkinTestRunner.cs                | 32 +++++++++++++++++---
 .../Gherkin/IgnoreException.cs                  | 17 ++++++++---
 2 files changed, 40 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/bbb13772/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
----------------------------------------------------------------------
diff --git 
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs 
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
index f3e823a..4a1d646 100644
--- 
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
+++ 
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs
@@ -37,11 +37,33 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
 {
     public class GherkinTestRunner
     {
-        private static readonly IDictionary<string, IgnoreReason> 
IgnoredScenarios = new Dictionary<string, IgnoreReason> {
-            { 
"g_V_hasLabelXpersonX_hasXage_notXlteX10X_andXnotXbetweenX11_20XXXX_andXltX29X_orXeqX35XXXX_name",
 IgnoreReason.NeedsFurtherInvestigation }, // TINKERPOP-1859??
-            { "g_VX1X_out_aggregateXxX_out_whereXnotXwithinXaXXX", 
IgnoreReason.NeedsFurtherInvestigation }, // TINKERPOP-1859??
-            { "g_withBulkXfalseX_withSackX1_sumX_V_out_barrier_sack", 
IgnoreReason.NeedsFurtherInvestigation } // TINKERPOP-1907
-        };
+        private static readonly IDictionary<string, IgnoreReason> 
IgnoredScenarios =
+            new Dictionary<string, IgnoreReason>
+            {
+                {
+                    
"g_withSackX1_sumX_VX1X_localXoutXknowsX_barrierXnormSackXX_inXknowsX_barrier_sack",
+                    IgnoreReason.NumericalValuesHaveWrongTypes
+                },
+                {"g_withBulkXfalseX_withSackX1_sumX_V_out_barrier_sack", 
IgnoreReason.NumericalValuesHaveWrongTypes},
+                {"g_V_hasIdXwithinXemptyXX_count", 
IgnoreReason.PWithinWrapsArgumentsInArray},
+                {"g_VX1X_out_aggregateXxX_out_whereXnotXwithinXaXXX", 
IgnoreReason.PWithinWrapsArgumentsInArray},
+                {
+                    
"g_V_hasLabelXpersonX_hasXage_notXlteX10X_andXnotXbetweenX11_20XXXX_andXltX29X_orXeqX35XXXX_name",
+                    IgnoreReason.PNotCreatedCorrectlyByGherkinRunner
+                },
+                {
+                    
"g_V_asXaX_outXcreatedX_asXbX_inXcreatedX_asXcX_bothXknowsX_bothXknowsX_asXdX_whereXc__notXeqXaX_orXeqXdXXXX_selectXa_b_c_dX",
+                    IgnoreReason.PNotCreatedCorrectlyByGherkinRunner
+                },
+                {
+                    
"g_V_asXaX_outEXcreatedX_asXbX_inV_asXcX_whereXa_gtXbX_orXeqXbXXX_byXageX_byXweightX_byXweightX_selectXa_cX_byXnameX",
+                    IgnoreReason.PNotCreatedCorrectlyByGherkinRunner
+                },
+                {
+                    
"g_V_asXaX_outEXcreatedX_asXbX_inV_asXcX_inXcreatedX_asXdX_whereXa_ltXbX_orXgtXcXX_andXneqXdXXX_byXageX_byXweightX_byXinXcreatedX_valuesXageX_minX_selectXa_c_dX",
+                    IgnoreReason.PNotCreatedCorrectlyByGherkinRunner
+                }
+            };
         
         private static class Keywords
         {

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/bbb13772/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs
----------------------------------------------------------------------
diff --git 
a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs 
b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs
index 0179994..c8cb29a 100644
--- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs
+++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs
@@ -41,10 +41,17 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
             switch (reason)
             {
                 case IgnoreReason.LambdaNotSupported:
-                    reasonSuffix = " because lambdas are not supported in 
Gremlin.NET";
+                    reasonSuffix = " because lambdas are not supported in 
Gremlin.NET (TINKERPOP-1854)";
                     break;
-                case IgnoreReason.NeedsFurtherInvestigation:
-                    reasonSuffix = " as further investigation is required";
+                case IgnoreReason.PNotCreatedCorrectlyByGherkinRunner:
+                    reasonSuffix =
+                        " because the Gherkin runner can't call methods in 
TraversalPredicate class (TINKERPOP-1919)";
+                    break;
+                case IgnoreReason.NumericalValuesHaveWrongTypes:
+                    reasonSuffix = " because the asserts currently fail due to 
type mismatches (TINKERPOP-1918)";
+                    break;
+                case IgnoreReason.PWithinWrapsArgumentsInArray:
+                    reasonSuffix = " because P.Within() arguments are 
incorrectly wrapped in an array (TINKERPOP-1920)";
                     break;
             }
             return $"Scenario ignored" + reasonSuffix;
@@ -54,6 +61,8 @@ namespace Gremlin.Net.IntegrationTest.Gherkin
     public enum IgnoreReason
     {
         LambdaNotSupported,
-        NeedsFurtherInvestigation
+        PNotCreatedCorrectlyByGherkinRunner,
+        NumericalValuesHaveWrongTypes,
+        PWithinWrapsArgumentsInArray
     }
 }
\ No newline at end of file

Reply via email to