dkuppitz commented on a change in pull request #999: some improvements URL: https://github.com/apache/tinkerpop/pull/999#discussion_r235104014
########## File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalStrategies.java ########## @@ -25,25 +25,23 @@ import java.util.ArrayList; import java.util.Collections; +import java.util.LinkedHashSet; import java.util.List; import java.util.Optional; +import java.util.Set; /** * @author Marko A. Rodriguez (http://markorodriguez.com) */ public class DefaultTraversalStrategies implements TraversalStrategies { - protected List<TraversalStrategy<?>> traversalStrategies = new ArrayList<>(); + protected Set<TraversalStrategy<?>> traversalStrategies = new LinkedHashSet<>(); @Override @SuppressWarnings({"unchecked", "varargs"}) public TraversalStrategies addStrategies(final TraversalStrategy<?>... strategies) { - final List<TraversalStrategy<?>> concurrent = new ArrayList<>(this.traversalStrategies); for (final TraversalStrategy<?> addStrategy : strategies) { - for (final TraversalStrategy<?> currentStrategy : concurrent) { - if (addStrategy.getClass().equals(currentStrategy.getClass())) - this.traversalStrategies.remove(currentStrategy); - } + this.traversalStrategies.remove(addStrategy); Review comment: Yea, I just tried to get rid of the loop, but that doesn't work because at some point we rely on a replacement behavior. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
