spmallette commented on issue #1001: uses the directly field instead of getter method URL: https://github.com/apache/tinkerpop/pull/1001#issuecomment-446166206 I believe that I need to revert/modify some of these changes. For classes that are designed for extension, like `GraphStep` it's possible that a method called in the subclass could be overridden to not use the field (somewhat unlikely in these cases but remotely possible) in which case the behavior we've had would be broken. I intend to go through each change and either fully revert it or in cases where the performance improvement is important (i.e. GraphSON) I will keep the change but add a `final` to the method declaration to ensure that it's not overridden with the expectation that it will alter behavior somewhere else. The use of `final` is technically a breaking change so it should probably only happen on `master`. I'm not sure what that means for #1014 at this point. Maybe we should just keep this change to `master` only.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
