spmallette commented on issue #1013: TINKERPOP-2105 - connection.py - add finally to return connection to the client pool i… URL: https://github.com/apache/tinkerpop/pull/1013#issuecomment-447819615 Thanks for fixing the existing tests. Two things: 1. I presume this is a bug on 3.3.x as well as the unreleased 3.4.0. If so, could you please re-target this PR at the `tp33` branch 2. You provided a small python script to reproduce that problem. Is there any reason you could not convert that into a test as part of this PR so that we have some insurance against regression? > ideally the client (who handle the connection pool) should allocate and free the connections and not the connection itself I think your approach is fine, but I suppose that the `Client` which borrows the `Connection` should be the thing to return it to the pool. If you felt like refactoring that at some point I think that approach would be ok as well. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
