jorgebay commented on a change in pull request #1012: TINKERPOP-1889 - Upgrade
ws, adding ping and reconnection javascript
URL: https://github.com/apache/tinkerpop/pull/1012#discussion_r243187538
##########
File path:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/connection.js
##########
@@ -151,6 +183,64 @@ class Connection {
});
}
+ _pingHeartbeat() {
+ if (this._pingEnabled === false) {
Review comment:
Nit: unnecessary double check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
