jorgebay commented on a change in pull request #1016: Add request pipelining
and a fixed ConnectionPool size TINKERPOP-1775 and TINKERPOP-1774
URL: https://github.com/apache/tinkerpop/pull/1016#discussion_r243535711
##########
File path: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs
##########
@@ -154,6 +159,67 @@ private string SaslArgument()
return Convert.ToBase64String(authBytes);
}
+ private void BeginSendingMessages()
+ {
+ if (Interlocked.CompareExchange(ref _writeInProgress, 1, 0) != 0)
+ return;
+ SendNextMessageFromQueue();
+ Interlocked.CompareExchange(ref _writeInProgress, 0, 1);
Review comment:
The mix of async code (`ContinueWith()` on `SendNextMessageFromQueue()`) and
sync code will cause a race condition, we should only change `_writeInProgress`
to `0` when we finish dequeueing all items.
The easiest solution would be to move this set statement to the
`SendNextMessageFromQueue()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
