FlorianHockmann commented on a change in pull request #1016: Add request pipelining and a fixed ConnectionPool size TINKERPOP-1775 and TINKERPOP-1774 URL: https://github.com/apache/tinkerpop/pull/1016#discussion_r243819211
########## File path: gremlin-dotnet/src/Gremlin.Net/Driver/SingleMessageResultReceiver.cs ########## @@ -0,0 +1,88 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; +using System.Collections.Generic; +using System.Threading.Tasks; +using Gremlin.Net.Driver.Messages; +using Gremlin.Net.Driver.ResultsAggregation; +using Gremlin.Net.Structure.IO.GraphSON; +using Newtonsoft.Json.Linq; + +namespace Gremlin.Net.Driver +{ + internal class ResponseHandlerForSingleRequestMessage<T> : IResponseHandlerForSingleRequestMessage + { + public Task<ResultSet<T>> Result => _tcs.Task; + + private readonly TaskCompletionSource<ResultSet<T>> _tcs = + new TaskCompletionSource<ResultSet<T>>(TaskCreationOptions.RunContinuationsAsynchronously); + + private readonly GraphSONReader _graphSONReader; + private bool _isAggregatingSideEffects; + private IAggregator _aggregator; + private readonly List<T> _result = new List<T>(); + + public ResponseHandlerForSingleRequestMessage(GraphSONReader graphSonReader) + { + _graphSONReader = graphSonReader; + } + + public void HandleReceived(ResponseMessage<JToken> received) + { + var receivedData = typeof(T) == typeof(JToken) + ? new[] {received.Result.Data} + : _graphSONReader.ToObject(received.Result.Data); Review comment: You mean that `_graphSONReader.ToObject()` shouldn't return `dynamic`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
