robertdale commented on a change in pull request #1075: Docker gremlin-server test script URL: https://github.com/apache/tinkerpop/pull/1075#discussion_r262040172
########## File path: docker/gremlin-server/Dockerfile.template ########## @@ -0,0 +1,27 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +FROM tinkerpop:hadoop-HADOOP_VERSION Review comment: We could do that. The only challenge I see is copying the test data to the image. Currently, it's copied from the working copy. What if you wanted to test 3.2.x server with a 3.4.x client? How do we access the test data from 3.2.x to copy it over? How do we know if the test data is compatible? Finally, what would this look like? `./docker/gremlin-server.sh --version 3.2.9`? Then without `--version` it uses the working copy? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
