FlorianHockmann commented on a change in pull request #1250: fix for
https://issues.apache.org/jira/browse/TINKERPOP-2192
URL: https://github.com/apache/tinkerpop/pull/1250#discussion_r386452437
##########
File path: gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs
##########
@@ -126,11 +130,14 @@ private void Parse(byte[] received)
{
if (_callbackByRequestId.TryRemove(receivedMsg.RequestId, out
var responseHandler))
{
- responseHandler.HandleFailure(e);
+ responseHandler?.HandleFailure(e);
}
}
}
+ private static void ThrowMessageDeserializedNull() =>
+ throw new InvalidOperationException("Received data deserialized
into null object message. Cannot operated on it.");
Review comment:
Just a small grammatical nitpick, but it should be _operate on it_ (without
a "d") afaik.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
