FlorianHockmann commented on a change in pull request #1263: dotnet: add
session mode connection
URL: https://github.com/apache/tinkerpop/pull/1263#discussion_r401582778
##########
File path:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs
##########
@@ -285,12 +285,22 @@ public async Task
ShouldSaveVariableBetweenRequestsInSession()
var gremlinServer = new GremlinServer(TestHost, TestPort);
using (var gremlinClient = new GremlinClient(gremlinServer,
sessionId: Guid.NewGuid().ToString()))
{
-
await gremlinClient.SubmitWithSingleResultAsync<int>("x = 1");
var response = await
gremlinClient.SubmitWithSingleResultAsync<int>("x + 2");
Assert.Equal(3, response);
}
}
+
+ [Fact]
+ public void ShouldThrowOnExecutionOfMultiConnectionInPool()
Review comment:
The test looks good in general, but it is not really an integration test as
it works without any external dependencies like a Gremlin Server instance.
Could you therefore please move it into the `Gremlin.Net.UnitTest` project? You
can create a new class `GremlinClientTests` in the `Driver` directory there as
there probably are no unit tests yet for this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
