spmallette commented on issue #1264: gremlin-python: add session mode client URL: https://github.com/apache/tinkerpop/pull/1264#issuecomment-607317401 @heljoyLiu If you'd like to try to include the documentation changes I suggested above on this PR that would be great, otherwise I will look to add them myself on merge. Also note that you intended to fix this in Javascript: https://github.com/apache/tinkerpop/pull/1251/files#diff-9ec1348d608a722cece8543e6db87a23R385 If you'd like to add that here on this PR that will be fine, though for some reason you target `3.4-dev` with this PR but all other languages went to `3.3-dev` - I think this change should be re-targetted to `3.3-dev` to be consistent at this point. Please let me know if you think differently for some reason. As a reminder to myself, on the merge of this one to `master` we probably need to review the impact of: https://issues.apache.org/jira/browse/TINKERPOP-2336 https://github.com/apache/tinkerpop/blob/0a7769eea651ab0e72d3a6a0bd424fbb1197bd47/docs/src/upgrade/release-3.5.x.asciidoc#session-close in the context of python/js/.net merging to `master`. Ultimately we want consistency of behavior across all the drivers, so these should be modified to match java (i.e. remove the send of the close message and validate that the close of the channel kills the session). Well, I hope I've captured all the loose ends on this "session" feature. If anyone has anything else they might add please comment. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
