spmallette commented on pull request #1280:
URL: https://github.com/apache/tinkerpop/pull/1280#issuecomment-619941045
Travis seems to be passing tests now and this change seems like a good one.
I'm not sure why we didn't have it this way before. We were already coercing
`long()` to `BigInt` so I'm not sure why we wouldn't do the same for int. It
makes me wonder if it's an inconsistency to not have an explicit `bigint()`
function. I realize that Python developers don't think of numbers the way that
Java developers do but if a Java server process explicitly required a `BigInt`
and the user needed to send the number `1` of that type they wouldn't have a
way to do it. There is no need for you to resolve that issue on this ticket,
but perhaps it is worth creating a JIRA for it. Perhaps it would only be a
feature for {{master}} and 3.5.0.
Finally, a couple of administrative points:
1. It would be nice if you could include a [CHANGELOG
entry](https://github.com/apache/tinkerpop/blob/3.3-dev/CHANGELOG.asciidoc#tinkerpop-3311-release-date-not-officially-released-yet)
that describes your change a bit. While we add JIRA ticket references to this
file on release, we like to include short summaries of each change that goes in.
2. Could you please rebase and squash these commits after the changes I
suggested are resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
