spmallette commented on pull request #1506: URL: https://github.com/apache/tinkerpop/pull/1506#issuecomment-977923740
> The SymbolHelper map has been updated to include the missing reserved words/global functions differences for built in Python keywords I made a similar change on #1530 headed to `master`. I was going to backport it but this works too. as this is your second PR, i'd point out that we like a CHANGELOG entry included with changes - a bullet or two that describes the nature of your changes (this is separate from including JIRA information which you also see in the CHANGELOG which is added when we do a release). If you'd like to update this PR with such an entry you would add it for 3.5.2 here: https://github.com/apache/tinkerpop/blob/master/CHANGELOG.asciidoc#tinkerpop-352-release-date-not-officially-released-yet Otherwise, no worries this time - I can add it when I merge. From an administrative perspective, It would be nice if you could rebase/squash this PR to a single commit so the git history stays nice/compact. Thanks for the contribution! Hope to see you again 🙂 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
