FlorianHockmann commented on a change in pull request #1551:
URL: https://github.com/apache/tinkerpop/pull/1551#discussion_r787737917
##########
File path:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Process/Remote/RemoteStrategyTests.cs
##########
@@ -1,4 +1,4 @@
-#region License
Review comment:
I at least remember that we had some problems with this already in the
past. I think some IDE (maybe Visual Studio) added the BOM byte to files which
resulted in problems for others. I think we should remove it everywhere.
We could add an `.editorconfig` where we specify the charset as `utf-8` for
all `*.cs` files. Most editors / IDEs support `.editorconfig` (a plugin might
be necessary though) which should ensure that the BOM byte doesn't get added
back. We can also use a GitHub action to enforce that the `.editorconfig` is
honored.
This issue contains more details: editorconfig/editorconfig#297.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
