FlorianHockmann commented on pull request #1565: URL: https://github.com/apache/tinkerpop/pull/1565#issuecomment-1036348363
> Looks like [the scenarios where I changed the expected result type from decimal to double](https://github.com/apache/tinkerpop/pull/1564/commits/599d2eeb7bb1c8d88cb4561e494e9dab75feb8da#diff-5722803f3bf83fc6999422a5d9a46d3c40799f86b1566216b30a24fb9c3a3ce4) are now failing here for TinkerGraph, although they passed for 3.5-dev. I'm not sure yet why they passed for 3.5-dev, but not for master here. Will have to look into that. I guess I shouldn't have changed these scenarios at all as we're using `BigDecimal` per default there in Java and not `double` so `decimal`/`BigDecimal` should really be the expected type. So, I've updated #1564 to instead allow `double` values in the Gherkin .NET tests when `decimal` is expectedand also updated this branch afterwards. Hope this fixes the problem also for `master` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
