spmallette commented on a change in pull request #1570:
URL: https://github.com/apache/tinkerpop/pull/1570#discussion_r809583093
##########
File path:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
##########
@@ -2473,6 +2473,8 @@ else if (value instanceof Traversal)
property(key, entry.getKey(), entry.getValue());
}
return this;
+ } else if (value == null) { // Just return the input if you pass a
null
+ return this;
Review comment:
just a side effect to consider here...by returning `this` we don't
modify the traversal/bytecode which means that if you were to do a `profile()`,
`toString()`, use a `Translator`, etc. you wouldn't get and exact
representation of the Gremlin that you executed. i've generally tried to avoid
this problem in other cases with `null` arguments, but have questioned how
important it is at times. thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
