lyndonb-bq commented on a change in pull request #1571:
URL: https://github.com/apache/tinkerpop/pull/1571#discussion_r810224454
##########
File path:
gremlin-python/src/main/python/gremlin_python/driver/driver_remote_connection.py
##########
@@ -74,7 +79,19 @@ def __init__(self, url, traversal_source="g",
protocol_factory=None,
self._traversal_source = self._client._traversal_source
def close(self):
- logging.info("closing DriverRemoteConnection with url '%s'",
str(self._url))
+ # close this client and any DriverRemoteConnection instances spawned
from this one
+ # for a session
+ if len(self.__spawned_sessions) > 0:
+ logging.info("closing spawned sessions from DriverRemoteConnection
with url '%s'", str(self._url))
+ for spawned_session in self.__spawned_sessions:
+ spawned_session.close()
+
Review comment:
Perhaps we should clear the list here, since all the connections
maintained in the list are now closed?
```suggestion
for spawned_session in self.__spawned_sessions:
spawned_session.close()
self.__spawned_sessions.clear()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
