tkolanko commented on pull request #1539: URL: https://github.com/apache/tinkerpop/pull/1539#issuecomment-1058278224
@spmallette @jorgebay Here's where we are with this PR: 1. I've fixed up the formatting issues and will create a new JIRA ticket to implement a standard for linting the JS files 2. The tests are passing, however, there is a duplicated block of code that should be extracted out. The current client tests are overriding an internal object and they did not play nice with having that block of code extracted out. I need more time to figure out why that is. We can either hold off on this PR and fixed that up or we can merge this PR in and I can create a JIRA ticket to figure out a better way to remove the duplicated block of code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
