mikepersonick commented on pull request #1574: URL: https://github.com/apache/tinkerpop/pull/1574#issuecomment-1065158622
Just to echo what Stephen said: > Following things are missing from this review. Are you planning to pick them up as follow-up tasks? > > 1. Add queries in process suite integration tests for these steps. > 2. Add the new types such a ServiceRegistry to the serializers. A general question I have is around how the serializers (particularily graphbinary) will recognize the new tokens added in this reviews. 1. We decided to skip process suite tests in favor of just feature tests. Especially since these tests are only testable via Tinkergraph. That's why I put them directly in the Tinkergraph package. 2. All the ServiceRegistry stuff is part of the Graph API, not part of Gremlin or the remoting API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
