ihoro commented on PR #1547: URL: https://github.com/apache/tinkerpop/pull/1547#issuecomment-1134994636
I have got `integration` and `features` tests passed with current state of GraphBinary implementation (it's not 100% complete according to the spec). At least it works in my test env, it would be great to check it with official CI process. So, I would like to get the test process configured such way that both protocols are tested, GraphSON and GraphBinary. I've decided to make it so on the high level. From my quick overview, the lower levels seem to be tricky to configure. Please, consider [my approach](https://github.com/apache/tinkerpop/pull/1547/commits/6edeaee01254b5d095b3fb63cf68849627b6b2dd) and comment on, probably you would like to structure it another way according to the entire TinkerPop Maven project. If you are okay with that env var introduced, quite global one, then... probably, it's better to name it more officially instead of `*_TEST_*`, and follow some naming agreement if any; because of it's part of production code, i.e. it can be used in a prod case as well, not only in test one. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
