lyndonbauto commented on code in PR #1669:
URL: https://github.com/apache/tinkerpop/pull/1669#discussion_r882894831
##########
gremlin-go/driver/resultSet.go:
##########
@@ -120,6 +121,19 @@ func (channelResultSet *channelResultSet) Close() {
}
}
+// Close and remove from the channelResultSet from the container without
locking container. Meant for use when calling
Review Comment:
If it is used, perhaps we should have
`LockedClose()`
and
`unlockedClose()`
and both should call
```
func (channelResultSet *channelResultSet) close(locked bool) {
if !channelResultSet.closed {
channelResultSet.channelMutex.Lock()
channelResultSet.closed = true
if lock {
channelResultSet.container.delete(channelResultSet.requestID)
} else {
delete(channelResultSet.container.internalMap,
channelResultSet.requestID)
}
close(channelResultSet.channel)
channelResultSet.channelMutex.Unlock()
channelResultSet.sendSignal()
}
}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
