spmallette commented on code in PR #1837:
URL: https://github.com/apache/tinkerpop/pull/1837#discussion_r1002771053
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractEvalOpProcessor.java:
##########
@@ -231,9 +233,18 @@ protected void evalOpInternal(final Context ctx, final
Supplier<GremlinExecutor>
final GremlinExecutor.LifeCycle lifeCycle =
GremlinExecutor.LifeCycle.build()
.evaluationTimeoutOverride(seto)
.afterFailure((b,t) -> {
+ graphManager.onQueryError(msg, t);
if (managedTransactionsForRequest) attemptRollback(msg,
ctx.getGraphManager(), settings.strictTransactionManagement);
})
+ .afterTimeout(b -> {
Review Comment:
this is unfortunate. i assume there is no way to get the original time-out
exception thrown? do we really have to construct a fresh exception here just
for purpose of getting one to `onQueryError()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
