spmallette commented on code in PR #1835:
URL: https://github.com/apache/tinkerpop/pull/1835#discussion_r1003210814
##########
hadoop-gremlin/src/main/java/org/apache/tinkerpop/gremlin/hadoop/structure/io/graphson/GraphSONRecordWriter.java:
##########
@@ -58,11 +61,15 @@ public final class GraphSONRecordWriter extends
RecordWriter<NullWritable, Verte
public GraphSONRecordWriter(final DataOutputStream outputStream, final
Configuration configuration) {
this.outputStream = outputStream;
this.hasEdges =
configuration.getBoolean(Constants.GREMLIN_HADOOP_GRAPH_WRITER_HAS_EDGES, true);
- this.graphsonWriter = GraphSONWriter.build().mapper(
- GraphSONMapper.build().
-
version(GraphSONVersion.valueOf(configuration.get(Constants.GREMLIN_HADOOP_GRAPHSON_VERSION,
"V3_0"))).
- typeInfo(TypeInfo.PARTIAL_TYPES).
-
addRegistries(IoRegistryHelper.createRegistries(ConfUtil.makeApacheConfiguration(configuration))).create()).create();
+ GraphSONVersion graphSONVersion =
Review Comment:
nit: `final` local variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
