FlorianHockmann opened a new pull request, #1875: URL: https://github.com/apache/tinkerpop/pull/1875
This is a follow-up to #1867 to now also enable nullable annotations to tests. https://issues.apache.org/jira/browse/TINKERPOP-2348 Only the generated Gherkin test traversals are missing as we would have to let the Java `DotNetTranslator` produce C# code with nullable annotations. I think we should do that at some point in the future as nullable annotations are only enabled since .NET 6 by default and only for new projects. So, many users are probably still not using them. Adding the annotations also in tests revealed two (well actually three) more places where `null` should be allowed in Gremlin.Net itself: In `Traversal.Equals()` and in the `From()`/`To()` steps if the argument is a `Vertex`. While `null` is still not really allowed there, Gremlin throws a more meaningful exception message if it gets `null` and we might change that in the future to somehow allow `null` maybe. VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
