cole-bq opened a new pull request, #1876:
URL: https://github.com/apache/tinkerpop/pull/1876

   Progress towards 
[TINKERPOP-2480](https://issues.apache.org/jira/browse/TINKERPOP-2480)
   
   Adds a user agent to gremlin-dotnet which is sent as a request header during 
the web socket handshake.
   
   User agent follows the form of [Application Name] [GLV Name].[Version] 
[Language Runtime Version] [OS].[Version] [CPU Architecture]
   
   This behavior is enabled by default but can be disabled by setting the 
ConnectionPoolSettings.EnableUserAgentOnConnect configuration to false.
   
   Note: There are no tests included as part of this PR. My intention is to add 
integration tests to ensure that the user agent is being sent correctly once 
[TINKERPOP-2819](https://issues.apache.org/jira/browse/TINKERPOP-2819) has been 
merged. The existing dotnet glv tests are sufficient to show that this change 
does not introduce any faults into the driver. I have conducted manual tests to 
ensure that the changes are currently functioning correctly. My thoughts are 
that with a potential release approaching, it is worthwhile to have the user 
agent introduced now, with full validation coming soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to