divijvaidya commented on code in PR #1833:
URL: https://github.com/apache/tinkerpop/pull/1833#discussion_r1039565086
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java:
##########
@@ -123,7 +124,9 @@ protected void initChannel(final SocketChannel
socketChannel) throws Exception {
}
if (sslCtx.isPresent()) {
-
pipeline.addLast(sslCtx.get().newHandler(socketChannel.alloc(),
connection.getUri().getHost(), connection.getUri().getPort()));
+ SslHandler sslHandler =
sslCtx.get().newHandler(socketChannel.alloc(), connection.getUri().getHost(),
connection.getUri().getPort());
+ sslHandler.setHandshakeTimeoutMillis(0);
Review Comment:
I think that the new stack trace i.e. `[ERROR]
org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler - Could not
process the response javax.net.ssl.SSLHandshakeException: SSL handshake timed
out` is fine as it provides the reason for connection failure i.e. ssl timeout.
I am saying this because the alternative to go for a %age based timeout adds
another knob that the users have to tune and they don't have good heuristics to
tune it since the %age is a function of network weather at that moment. That is
the reason I have an inclination to avoid adding a new configuration or adding
a %age based solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
