cole-bq commented on PR #1873: URL: https://github.com/apache/tinkerpop/pull/1873#issuecomment-1338208731
I would like to take some time to explore an alternative solution to this issue. The main drawback of switching to FastNoSuchElementException is that it does not include a stack trace. There are some concerns about the impact of removing the stack trace from this exception. The current implementation of hasNext() throws and catches NoSuchElementException's which gives it the same performance bottleneck you are trying to avoid. I want to try and speed up hasNext() so that users can check it before calling next() if they want to avoid the performance penalty associated with the NoSuchElementException. I believe that a fast implementation of hasNext() would remove the need for this PR and would avoid the need to trade better exceptions for better performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
