spmallette commented on code in PR #1916:
URL: https://github.com/apache/tinkerpop/pull/1916#discussion_r1057652790
##########
gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinScriptCheckerTest.java:
##########
@@ -53,6 +104,14 @@ public void shouldIdentifyTimeoutAsStringKeySingleQuoted() {
getTimeout().get().longValue());
}
+ @Test
+ public void shouldIdentifyRequestIdAsStringKeySingleQuoted() {
+ assertEquals("db024fca-ed15-4375-95de-4c6106aef895",
GremlinScriptChecker.parse("g.with('requestId',
'db024fca-ed15-4375-95de-4c6106aef895').with(true).V().out('knows')").
Review Comment:
yes - should pick up any string really. modified one of the tests to do
uppercase uuid though to just make the test more realistic to what people would
submit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
