Cole-Greer opened a new pull request, #1946:
URL: https://github.com/apache/tinkerpop/pull/1946

   https://issues.apache.org/jira/browse/TINKERPOP-2767
   
   The existing error handling in TraversalOpProcessor and SessionOpProcessor 
during bytecode iteration was catching all exceptions sending an appropriate 
error response to the client. The OpProcessor however was not catching a 
StackOverflowError which could be induced by running a query which contains a 
large repeat step. This Error was being caught by FutureTask.run() but 
GremlinServer never wait's on this task or checks the results which caused this 
Error to be lost. A similar issue was found to exist in 
AbstractSession.process().
   
   This PR adjusts the existing error handling code to catch any Throwable 
during bytecode iteration so clients will receive error messages and codes for 
server errors as well as exceptions. Any errors are re-thrown such that the 
evalFuture FutureTask will continue to have an exception set correctly 
(although GremlinServer currently does not use this for anything).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to