disq commented on code in PR #1989:
URL: https://github.com/apache/tinkerpop/pull/1989#discussion_r1135208270
##########
gremlin-go/driver/connection.go:
##########
@@ -42,15 +42,15 @@ type connection struct {
}
type connectionSettings struct {
- authInfo *AuthInfo
- tlsConfig *tls.Config
- keepAliveInterval time.Duration
- writeDeadline time.Duration
- connectionTimeout time.Duration
- enableCompression bool
- readBufferSize int
- writeBufferSize int
- enableUserAgentOnConnect bool
+ authInfo AuthInfoProvider
Review Comment:
> There appears to be one test failing in the checks right now. The maven
logs can be a bit much to search through, I like to search for `❌` in the logs
to find the failing test quickly. It appears that
`gremlin-go/driver/gorillaTransporter.go:68` can sometimes result in a nil
pointer dereference.
Thank you for the clarification on how to run the tests locally.
The issue seems to be one of the tests setting `authInfo` to `nil`, which is
unexpected (and isn't done anywhere else in the codebase as far as I can tell)
so now `gorillaTransporter.getAuthInfo()` has a nil-check and returns
`NoopAuthInfo` if `nil`. `NoopAuthInfo` is an idempotent way of specifying a
zero-value for the `AuthInfoProvider` and can be used publicly as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
