Cole-Greer commented on PR #2157: URL: https://github.com/apache/tinkerpop/pull/2157#issuecomment-1650861179
Hi Itay, I wanted to follow up on my previous comment and build off of what Valentyn's comment. As Valentyn mentioned this will require support for additional types and more testing. I also think it would be nice if the tests were to use a `GraphTraversal` to construct the `Bytecode` similar to what is done in the python translator tests, I believe this would make the tests easier to read and write. Let me know if you need any help with this. There is a bit of a time crunch if you want to get this in our upcoming release as we are currently in code freeze. I think all of the python translator tests will need to be translated over and need to pass before we can proceed here. Also it would ideally be completed tomorrow to avoid jeopardizing the release. Please let me know if you have any questions regarding this. I will make a best effort to help get this included in the release but due to the timing it cannot be guaranteed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
