Cole-Greer commented on PR #2160: URL: https://github.com/apache/tinkerpop/pull/2160#issuecomment-1652818438
Hi Itay, Thanks for all the rapid changes to the PR. To build off of Valentyn’s comments once again, I think there are still additional types that will need to be supported in order for the translator to be considered complete. Support for the following will all be needed: - Translation of nested structures (within lists and maps) - Primitive types (Char, Byte/int8, Short/int16) - More common structure types (Date, Datetime, UUID, BigInteger, BigDecimal) - Strategies The [python translator](https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/python/gremlin_python/process/translator.py) is a good reference to follow for this. There is still an opportunity for this to be merged tomorrow morning (Thursday in the Americas) if its complete although the release process is already well underway so this would be the final chance to make it into the upcoming release. If there is only minor tweaks needed tomorrow morning we may be able to assist with getting it finished up and into the release. Thanks, Cole -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
