xiazcy commented on PR #2216: URL: https://github.com/apache/tinkerpop/pull/2216#issuecomment-1688996842
> I see this error in a build. How should I resolve it ? > > ``` > gremlin-javascript: Error occurred while calling a method on a Groovy class from classpath. InvocationTargetException: javax.script.ScriptException: java.lang.IllegalArgumentException: keys must be unique in SelectStep -> [Help 1] > ``` This looks like the build is failing when trying to generate the Gherkin Feature test traversals file for javascript through `gremlin-javascript/build/generate.groovy`, which looks like is due to a Select Feature test case that is now failing the new error condition introduced in this PR: https://github.com/apache/tinkerpop/blob/e0779f768289a5e436523c7c6fd7ac1b0f660c37/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/Select.feature#L895 You might need to look into the test, which is presenting a potential use case, and see if it needs to be changed with this new behaviour you are introducing. This also ties into a general comment, I'd recommend adding Gherkin Feature tests for these step behaviour changes in addition to unit tests. An example for asserting errors in Feature tests is here: https://github.com/apache/tinkerpop/blob/e0779f768289a5e436523c7c6fd7ac1b0f660c37/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/MergeVertex.feature#L969 I usually run these Feature tests through TinkerGraph locally with this test, which runs all the steps: `tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
