Cole-Greer commented on PR #2213:
URL: https://github.com/apache/tinkerpop/pull/2213#issuecomment-1692113672
@itaywol Looks like your new changes broke one of the new tests:
```
gremlin-go-integration-tests | ❌
Test_translator_Translate/g.withStrategies(new_PartitionStrategy(includeMetaProperties:false,partitionKey:'partition',writePartition:'a',readPartitions:['a'])).addV('test')
(0s)
gremlin-go-integration-tests | translator_test.go:676:
translator.Translate() = g.withStrategies(new
PartitionStrategy(readPartitions:['a'],includeMetaProperties:false,partitionKey:'partition',writePartition:'a')).addV('test'),
equals g.withStrategies(new
PartitionStrategy(includeMetaProperties:false,partitionKey:'partition',writePartition:'a',readPartitions:['a'])).addV('test')
```
Seems like the order of the arguments to `new PartitionStrategy` are getting
shuffled for some reason. However both the expected and actual output for this
test are semantically equivalent as we are dealing with named parameters in
this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
