Cole-Greer commented on PR #2217: URL: https://github.com/apache/tinkerpop/pull/2217#issuecomment-1701807339
Thanks for putting this together. Overall the change looks good to me. If possible it would be nice to have a feature test for this just to ensure there are no issues in the GLV's. A good example of feature tests catching errors can be found here: https://github.com/apache/tinkerpop/blob/397eff08f73ae555bd3aab87498b9ff131792741/gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/map/MergeVertex.feature#L769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
