vkagamlyk commented on code in PR #2284:
URL: https://github.com/apache/tinkerpop/pull/2284#discussion_r1358668529
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java:
##########
@@ -71,6 +71,7 @@ protected void encode(final ChannelHandlerContext
channelHandlerContext, final R
gremlin = gremlinStringOrBytecode.toString();
}
final byte[] payload = mapper.writeValueAsBytes(new
HashMap<String,Object>() {{
+ this.putAll(requestMessage.getArgs());
put(Tokens.ARGS_GREMLIN, gremlin);
put(Tokens.REQUEST_ID, requestMessage.getRequestId());
Review Comment:
request id is not part of Args.
It would be nice to add a test that will confirm that the bindings work
correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
