xiazcy commented on code in PR #2329:
URL: https://github.com/apache/tinkerpop/pull/2329#discussion_r1385719950
##########
gremlin-python/src/main/python/gremlin_python/driver/connection.py:
##########
@@ -61,6 +61,7 @@ def write(self, request_message):
request_id = str(uuid.uuid4())
if request_message.args.get("requestId"):
request_id = request_message.args.get("requestId")
+ uuid.UUID(request_id) # The server will return an error if
non-UUID sent.
Review Comment:
```suggestion
uuid.UUID(request_id) # checks UUID is not malformed as the
server will return an error if non-UUID sent.
```
Thought I'd add a bit more clarification that this is doing a check and not
the transformation. I was initially wondering why you didn't assign it back to
request id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
