spmallette commented on code in PR #2352:
URL: https://github.com/apache/tinkerpop/pull/2352#discussion_r1397220487
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java:
##########
@@ -2829,6 +2830,19 @@ public default <S2> GraphTraversal<S, E> any(final P<S2>
predicate) {
return this.asAdmin().addStep(new AnyStep<>(this.asAdmin(),
predicate));
}
+ /**
+ * Filters <code>E</code> lists given the provided {@code predicate}.
+ *
+ * @param predicate the filter to apply
+ * @return the traversal with an appended {@link ListNoneStep}
+ * @see <a
href="http://tinkerpop.apache.org/docs/${project.version}/reference/#none-step";
target="_blank">Reference Documentation - None Step</a>
+ * @since 3.7.1
+ */
+ public default <S2> GraphTraversal<S, E> none(final P<S2> predicate) {
+ this.asAdmin().getBytecode().addStep(Symbols.listNone, predicate);
+ return this.asAdmin().addStep(new ListNoneStep<>(this.asAdmin(),
predicate));
Review Comment:
I realize `NoneStep` is already taken and has special meaning that is not
easily removed at this moment. Given that `none()` is just `not(any())` and the
code for this `ListNoneStep` and `AnyStep`, i think it would be better to just
give `AnyStep` a negation configuration. Then you get rid of `ListNoneStep`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
